Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add AVM tests unit placeholder where missing #585

Merged
merged 11 commits into from
Oct 22, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Oct 22, 2023

Description

  • Add placeholder tests/unit/custom.tests.ps1 file where missing
  • Fixed typo in guidelines for the file

avm.res.insights.action-group

@eriqua eriqua added Bug Fix Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 22, 2023
@eriqua eriqua self-assigned this Oct 22, 2023
@eriqua eriqua requested a review from a team as a code owner October 22, 2023 16:11
@eriqua eriqua changed the title fix: Add tests unit placeholder where missing fix: Add AVM tests unit placeholder where missing Oct 22, 2023
@eriqua eriqua enabled auto-merge (squash) October 22, 2023 16:14
@eriqua eriqua merged commit a902e5e into Azure:main Oct 22, 2023
14 checks passed
@AlexanderSehr AlexanderSehr deleted the fix/tests-unit branch October 22, 2023 18:22
eriqua added a commit that referenced this pull request Oct 23, 2023
## Description

Add dedicated Pester `Context` for Top level module folder tests:
- Move test 
  - Module should contain a [` version.json `] file
- Add tests:
  - Module should contain a [` tests `] folder
  - Module should contain a [` tests/e2e `] folder
  - Module should contain a [` tests/e2e/*waf-aligned `] folder
  - Module should contain a [` tests/e2e/*defaults `] folder
- Module should contain one [` main.test.bicep `] file in each e2e test
folder
  - Module should contain a [` tests/unit `] folder
  - Module should contain a [` tests/unit/custom.tests.ps1 `] file

Depending on #585 


[![avm.res.network.private-endpoint](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.network.private-endpoint.yml/badge.svg?branch=feat%2Fpester-test-folders)](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.network.private-endpoint.yml)

[![avm.res.key-vault.vault](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml/badge.svg?branch=feat%2Fpester-test-folders)](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.key-vault.vault.yml)

[![avm.res.insights.action-group](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.insights.action-group.yml/badge.svg?branch=feat%2Fpester-test-folders)](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.insights.action-group.yml)
(missing tests/unit folder and placeholder, solved by #585 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants